Home Forum Developers General discussions [PATCH] Makefile fixes

JRPassphrase Registration Control

In order to register on this site, you must first submit the passphrase below.

TODO list for each hardware target can be found as sticky topic in the corresponding forum

Page:   1 

1  Top
Jun-10-11 01:23:24
Chewi
useravatar
User Info

[PATCH] Makefile fixes

I'm not sure what it's usually like but building trunk is certainly quite problematic at the moment! Most of the errors were down to the change in GNU make and this only occured within the upstream makefiles, which we have limited control of. Fair enough. However, there was also a problem with Switchfin's own makefiles where it was assumed that there is only entity in build_ip04/root/lib/modules. I also have symlinks for "build" and "source" in there. It is not unusual for these symlinks to be there. To cut a long story short, this causes the installation of kernel modules to make a mess and sometimes result in an error. If we assume that the kernel name always ends in "switchfin" then the following patch will fix the problem.

http://www.aura-online.co.uk/~chewi/swi … iles.patch


Edited By:  Chewi
Jun-13-11 18:54:15

Administrator has disabled public posting
2  Top
Jun-15-11 18:08:46
admin
useravatar
User Info

Re: [PATCH] Makefile fixes

Hi Chewi,

Well we do have entity in build_ip04/root/lib/modules as we have to rebuild the whole image from scratch in case of kernel update.

Your approach is however probably safer.
I'll test later on today and will add it in the SVN

Cheers
Dimitar

Administrator has disabled public posting
3  Top
Jun-15-11 18:20:32
Chewi
useravatar
User Info

Re: [PATCH] Makefile fixes

I missed a word there, it should have been only *one* entity. In other words, the directory is assumed to only contain 2.6.34.7-ADI-2010R1switchfin or similar. Interestingly, I have rebuilt the image since and the "build" and "source" symlinks have disappeared. Still, it's best not to assume the contents of this directory. Checking for 2.6.* might have been a safe bet until a couple of weeks ago. wink Also, "tail -n1" makes sure it picks the newest kernel version rather than the oldest one.

Administrator has disabled public posting
4  Top
Jun-17-11 00:24:01
admin
useravatar
User Info

Re: [PATCH] Makefile fixes

Hi James,

You patch is tested and put in the SVN.

You have permission to commit in the Switchfin SVN now. 

Cheers
Dimitar

Administrator has disabled public posting
5  Top
Jun-17-11 00:47:41
Chewi
useravatar
User Info

Re: [PATCH] Makefile fixes

As a thank you for adding me, I've just committed something rather cool. smile

Administrator has disabled public posting
6  Top
Jun-17-11 17:11:44
admin
useravatar
User Info

Re: [PATCH] Makefile fixes

Hi James,

Thanks for adding N2N version 2.
Please share your experience with it after you test it.

To clarify, in n2n ver2 the emphasis is put on the security.

Cheers smile
Dimitar

Administrator has disabled public posting
7  Top
Jun-26-11 11:44:01
admin
useravatar
User Info

Re: [PATCH] Makefile fixes

Hi James,

I saw you have committed "Patch against the mixed rules errors raised by recent versions of GNU Make." in SVN.

Can you please describe what is the issue it fixes?

Cheers
Dimitar

Administrator has disabled public posting
8  Top
Jun-26-11 12:07:19
Chewi
useravatar
User Info

Re: [PATCH] Makefile fixes

From the Blackfin uClinux FAQ...

Busybox build fails with "mixed implicit and normal rules"

Newer versions of GNU make changed their handling of implicit rules and did so in a backwards incompatible way.
It goes on to say that a fix has been committed to SVN but the patch it references only fixes Busybox. I found more instances of the problem in other parts of the distribution. For your information, I have make 3.82.

Administrator has disabled public posting
9  Top
Jun-27-11 11:13:21
admin
useravatar
User Info

Re: [PATCH] Makefile fixes

Hi James,

Thanks for the patch and for the explanation.

It seems in 3.82 mixing of normal and implicit rules is not allowed anymore.
I am using gmake 3.81 tats why I was OK without the patch.

I confirm that your patch seems to work fine on 3.81. Feel free to expand the patch if you hit other places in the distro with the same issue.

Cheers
Dimitar

Administrator has disabled public posting
Page:   1 

Board Info

Board Stats:   Total Users: 2583  Total Topics: 290  Total Polls: 1  Total Posts: 1725  Dormant
User Info:   Newest User :  ZS6GDM   Members Online: 0   Guests Online: 45
Online  There are no members online
Topic
New
Locked
Topic
New
Locked
Sticky
Active
New/Active
Sticky
Active
New/Active
New/Closed
New Sticky
Closed/Active
New/Locked
New Sticky
Locked/Active
Active/Sticky
Sticky/Locked
Sticky Active Locked
Active/Sticky
Sticky/Locked
Sticky/Active/Locked